[Mlir-commits] [mlir] e9bc4aa - [mlir][gpu][docs] fix incorrect syntax for gpu.launch (#76381)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Thu Dec 28 08:43:59 PST 2023


Author: youkaichao
Date: 2023-12-28T11:43:55-05:00
New Revision: e9bc4aaa7942af8dee7983fd077fe7c4a805aae0

URL: https://github.com/llvm/llvm-project/commit/e9bc4aaa7942af8dee7983fd077fe7c4a805aae0
DIFF: https://github.com/llvm/llvm-project/commit/e9bc4aaa7942af8dee7983fd077fe7c4a805aae0.diff

LOG: [mlir][gpu][docs] fix incorrect syntax for gpu.launch (#76381)

Per the code:

https://github.com/llvm/llvm-project/blob/5c39b8d1a86cc0c92acd438d4799d19e67ae70db/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td#L805

And the usage:

https://github.com/llvm/llvm-project/blob/5c39b8d1a86cc0c92acd438d4799d19e67ae70db/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp#L869

The keyword should be `blocks` rather than `block`. The documentation of
the syntax is out of date.

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/GPU/IR/GPUOps.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td b/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td
index b536b6c97cef0d..efef61b5c6e712 100644
--- a/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td
+++ b/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td
@@ -713,7 +713,7 @@ def GPU_LaunchOp : GPU_Op<"launch", [
 
     ```
     operation ::= `gpu.launch` (`async` (`[` ssa-id-list `]`)? )?
-                             `block` `(` ssa-id-list `)` `in` ssa-reassignment
+                             `blocks` `(` ssa-id-list `)` `in` ssa-reassignment
                              `threads` `(` ssa-id-list `)` `in` ssa-reassignment
                              (dynamic_shared_memory_size ssa-use)?
                              memory-attribution


        


More information about the Mlir-commits mailing list