[Mlir-commits] [mlir] [mlir] Declare promised interfaces for the ConvertToLLVM extension (PR #76341)
Fabian Mora
llvmlistbot at llvm.org
Tue Dec 26 05:17:26 PST 2023
https://github.com/fabianmcg approved this pull request.
LGTM! When merging, change the commit message to remove the `note`. Something along the lines of:
```
This PR adds promised interface declarations for `ConvertToLLVMPatternInterface` in all the dialects that support the `ConvertToLLVM` dialect extension.
Promised interfaces allow a dialect to declare that it will have an implementation of a particular interface, crashing the program if one isn't provided when the interface is used.
```
Also, please build the change locally with `BUILD_SHARED_LIBS=ON` to detect any missing linking dependencies, and then run `ninja check-mlir` to verify all tests succeed.
Thanks!
https://github.com/llvm/llvm-project/pull/76341
More information about the Mlir-commits
mailing list