[Mlir-commits] [mlir] [mlir][Transforms] `GreedyPatternRewriteDriver`: Check for out-of-scope IR modifications (PR #76219)

[Jeff Niu]

Mogball wrote:

> > Note: TileAllocation (ArmSME dialect) must now be a module pass because it modifies func.func ops (adds attributes). This is forbidden for function passes
> 
> I would think we'd allow this though. @Mogball WDYT?

I believe the restriction on nested passes is that the parent op is ready only, whilst sister ops cannot be read or written. Modifying the op itself is fine, so this pass can remain a function pass.

https://github.com/llvm/llvm-project/pull/76219