[Mlir-commits] [mlir] [mlir][ArmSME] Add rudimentary support for tile spills to the stack (PR #76086)

Cullen Rhodes llvmlistbot at llvm.org
Thu Dec 21 07:02:10 PST 2023


================
@@ -200,37 +202,48 @@ static void findDependantOps(Value rootValue,
         });
   }
 }
-
 struct AssignTileIDsPattern
     : public OpInterfaceRewritePattern<ArmSMETileOpInterface> {
   using OpInterfaceRewritePattern::OpInterfaceRewritePattern;
   LogicalResult matchAndRewrite(ArmSMETileOpInterface tileOp,
                                 PatternRewriter &rewriter) const override {
+    auto func = tileOp->getParentOfType<FunctionOpInterface>();
     if (tileOp.getTileId())
       return failure();
 
----------------
c-rhodes wrote:

nit: move after if?
```suggestion
    if (tileOp.getTileId())
      return failure();
      
    auto func = tileOp->getParentOfType<FunctionOpInterface>();
```

https://github.com/llvm/llvm-project/pull/76086


More information about the Mlir-commits mailing list