[Mlir-commits] [mlir] [mlir][gpu] Allow subgroup reductions over 1-d vector types (PR #76015)

Fabian Mora llvmlistbot at llvm.org
Wed Dec 20 08:26:02 PST 2023


fabianmcg wrote:

> If we only allowed `vector<1xi32>` we would lose the semantic information that the lowering should perform reduction over `f32`. This is fine for `gpu.shuffle` as the reduction part happens in between the data movement, but not for `subgroup_reduce` which does perform reductions.

You're right, I was only thinking in the shuffling part. To be more specific my concern is things like `vector<4xf64>` or larger. Don't get me wrong I'm all in for supporting things like `vector<4xi8>`, but I'm not convinced it should support all sizes.


https://github.com/llvm/llvm-project/pull/76015


More information about the Mlir-commits mailing list