[Mlir-commits] [mlir] [mlir][python] meta region_op (PR #75673)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed Dec 20 06:56:47 PST 2023


================
@@ -93,3 +118,73 @@ def test_match_ops_mixed(op: OpHandle):
     # CHECK-NEXT: %[[VAL_1:.*]] = transform.structured.match
     # CHECK-SAME:   ops{["scf.for", "linalg.matmul", "scf.forall"]} in %[[VAL_0]]
     # CHECK-SAME:     -> !transform.any_op
+
+
+# CHECK-LABEL: TEST: test_sequence_region
+ at construct_and_print_in_module
+def test_sequence_region():
----------------
martin-luecke wrote:

These tests look more like integration tests to me as the transform script here seems to be meant to operate on the  generated payload IR.  Does it make sense to either:
- Move them to a different file and also run the TransformDialectInterpreter pass to check that the actually fit together and produce the correct output.
or:
- Only have the transform specific parts tested here

https://github.com/llvm/llvm-project/pull/75673


More information about the Mlir-commits mailing list