[Mlir-commits] [mlir] [mlir][python] Fixup the constantTypes of pdl.TypesOp (PR #75812)

[Jiefeng Wang]

jiefwo wrote:




> > rather than %0 = types which may result in PDL interpreter failure.
> 
> Sorry I'm not a `pdl` expert - what's the error?
> 
> Although I agree this could/should be just `None`, since `OptionalAttr` here
> 
> ```
> def PDL_TypesOp : PDL_Op<"types"> {
>   ...
>   let arguments = (ins OptionalAttr<TypeArrayAttr>:$constantTypes);
>   ...
> }
> ```
> 
> but it feels like this is a bug in how `pdl_interp.check_types` handles `[]`. @ftynse do you know what `pdl_interp` _should_ be doing here?

Thanks for your reply. I get this message from `-debug` information but not understand the meaning well.
```
[transform-dialect] ----recording invalidation for empty handle: mlir-asm-printer: Verifying operation: builtin.module
```

I'm not sure if it's a bug of `pdl_interp.check_types` or `pdl.py` as well.

https://github.com/llvm/llvm-project/pull/75812