[Mlir-commits] [mlir] [mlir][EmitC] Disallow string attributes as initial values (PR #75310)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Tue Dec 19 03:22:31 PST 2023
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff cb8690ff6fefecb15d73452899834d19b526e197 21aabe981a34d9d75788f7aea9a68af1b13f7e61 -- mlir/lib/Dialect/EmitC/IR/EmitC.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/mlir/lib/Dialect/EmitC/IR/EmitC.cpp b/mlir/lib/Dialect/EmitC/IR/EmitC.cpp
index 7da8e7ef53..08b4f3f361 100644
--- a/mlir/lib/Dialect/EmitC/IR/EmitC.cpp
+++ b/mlir/lib/Dialect/EmitC/IR/EmitC.cpp
@@ -52,8 +52,9 @@ void mlir::emitc::buildTerminatedBody(OpBuilder &builder, Location loc) {
/// Check that the type of the initial value is compatible with the operations
/// result type.
-static LogicalResult verifyInitializationAttribute(Operation *op, Attribute value,
- Type expectedType) {
+static LogicalResult verifyInitializationAttribute(Operation *op,
+ Attribute value,
+ Type expectedType) {
if (llvm::isa<emitc::OpaqueAttr>(value))
return success();
``````````
</details>
https://github.com/llvm/llvm-project/pull/75310
More information about the Mlir-commits
mailing list