[Mlir-commits] [mlir] [mlir][vector] Extend `CreateMaskFolder` (PR #75842)

Andrzej WarzyƄski llvmlistbot at llvm.org
Mon Dec 18 13:18:32 PST 2023


banach-space wrote:

> > For non-scalable dims:
> 
> I'm not sure if we should be fixing broken IR like that. 

That IR is valid (from [docs](https://mlir.llvm.org/docs/Dialects/Vector/#vectorcreate_mask-vectorcreatemaskop)):
> If operand-value is negative, it is treated as if it were zero, and **if it is greater than the corresponding dimension size, it is treated as if it were equal to the dimension size**.

Btw, this PR doesn't change the semantics of `vector.create_mask`.

https://github.com/llvm/llvm-project/pull/75842


More information about the Mlir-commits mailing list