[Mlir-commits] [mlir] [mlir][vector] Extend `CreateMaskFolder` (PR #75842)
Andrzej Warzyński
llvmlistbot at llvm.org
Mon Dec 18 12:32:57 PST 2023
banach-space wrote:
Thanks for taking a look Jakub!
> One thing that I didn't see tested is what happens when the operand is a constant larger than the dim size.
For non-scalable dims:
* https://github.com/llvm/llvm-project/blob/395f9ce30e884cb6ce02f7a3bdd0dd1f72ea9033/mlir/test/Dialect/Vector/canonicalize.mlir#L23-L30
For scalable dims (from [https://mlir.llvm.org/docs/Dialects/Vector/#vectorconstant_mask-vectorconstantmaskop](docs)):
> Sizes that correspond to scalable dimensions are implicitly multiplied by vscale, though currently only zero (none set) or the size of the dim/vscale (all set) are supported.
I check for that here: https://github.com/llvm/llvm-project/pull/75842/files#diff-c62b57552386a2a552ce6e3fe37bc23d399f2508636851b77ec6cd47fee906afR5728-R5729
I could add a negative test, but didn't see any in the test file 🤔 .
https://github.com/llvm/llvm-project/pull/75842
More information about the Mlir-commits
mailing list