[Mlir-commits] [mlir] [mlir][vector] Extend `CreateMaskFolder` (PR #75842)

Jakub Kuderski llvmlistbot at llvm.org
Mon Dec 18 11:17:48 PST 2023


https://github.com/kuhar commented:

Left some API suggestions.

One thing that I didn't see tested is what happens when the operand is a constant larger than the dim size. I don't know the semantics of `vector.create_maks`, but I would expect this to fail verification with attributes but not with constant operands. Folds should, in general, not introduce verifier errors by making the information more local.

https://github.com/llvm/llvm-project/pull/75842


More information about the Mlir-commits mailing list