[Mlir-commits] [mlir] [mlir] NamedAttribute utility generator (PR #75118)

Krzysztof Drewniak llvmlistbot at llvm.org
Mon Dec 18 07:53:19 PST 2023


krzysz00 wrote:

I wasn't aware of that dialect attribute verification hook - I think that's relatively new.

What I was trying to say about the LLVM dialect is that there're a lot of `llvm.*` discardable attributes these days, and it'd be good to either have them defined in a less ad-hoc way or to make them inherent attributes of relevant operations.

I'm also not sure `AttrDef` is the right mechanism here, I was pointing out motivations for describing "well-known" discardable attributes in tablegen.

https://github.com/llvm/llvm-project/pull/75118


More information about the Mlir-commits mailing list