[Mlir-commits] [mlir] Fix what seems to be a silly bug in gpu.set_default_device rewriting. Smoke test included. (PR #75756)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Sun Dec 17 15:17:28 PST 2023
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir
Author: Paul C Fuqua (pcf000)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/75756.diff
1 Files Affected:
- (modified) mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp (+3-2)
``````````diff
diff --git a/mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp b/mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp
index b68baffb5a8565..94df3765a67e74 100644
--- a/mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp
+++ b/mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp
@@ -1334,8 +1334,9 @@ LogicalResult ConvertSetDefaultDeviceOpToGpuRuntimeCallPattern::matchAndRewrite(
gpu::SetDefaultDeviceOp op, OpAdaptor adaptor,
ConversionPatternRewriter &rewriter) const {
Location loc = op.getLoc();
- setDefaultDeviceCallBuilder.create(loc, rewriter, {adaptor.getDevIndex()});
- rewriter.replaceOp(op, {});
+ auto call = setDefaultDeviceCallBuilder.create(loc, rewriter,
+ {adaptor.getDevIndex()});
+ rewriter.replaceOp(op, call);
return success();
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/75756
More information about the Mlir-commits
mailing list