[Mlir-commits] [mlir] Fix what seems to be a silly bug in gpu.set_default_device rewriting. Smoke test included. (PR #75756)

Paul C Fuqua llvmlistbot at llvm.org
Sun Dec 17 15:16:43 PST 2023


https://github.com/pcf000 created https://github.com/llvm/llvm-project/pull/75756

None

>From 6d5a558833671b13ad0f4c859263aec1b699fea8 Mon Sep 17 00:00:00 2001
From: Paul Fuqua <pf at acm.org>
Date: Sun, 17 Dec 2023 17:10:17 -0600
Subject: [PATCH] Fix what seems to be a silly bug in gpu.set_default_device
 rewriting. Smoke test included.

---
 mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp b/mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp
index b68baffb5a8565..94df3765a67e74 100644
--- a/mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp
+++ b/mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp
@@ -1334,8 +1334,9 @@ LogicalResult ConvertSetDefaultDeviceOpToGpuRuntimeCallPattern::matchAndRewrite(
     gpu::SetDefaultDeviceOp op, OpAdaptor adaptor,
     ConversionPatternRewriter &rewriter) const {
   Location loc = op.getLoc();
-  setDefaultDeviceCallBuilder.create(loc, rewriter, {adaptor.getDevIndex()});
-  rewriter.replaceOp(op, {});
+  auto call = setDefaultDeviceCallBuilder.create(loc, rewriter,
+                                                 {adaptor.getDevIndex()});
+  rewriter.replaceOp(op, call);
   return success();
 }
 



More information about the Mlir-commits mailing list