[Mlir-commits] [mlir] [mlir][Transform] Fix crash with invalid ir for transform libraries (PR #75649)

Kai Sasaki llvmlistbot at llvm.org
Fri Dec 15 22:24:48 PST 2023


================
@@ -0,0 +1,8 @@
+// RUN: mlir-opt %s --verify-diagnostics
+
+module attributes {transform.with_named_sequence} {
+  transform.named_sequence private @private_helper(%arg0: !transform.any_op {transform.readonly}) {
+    // expected-error @below {{expected ','}}
+    transform.test_print_remark_at_operand %arg0 "message" : !transform.any_op
----------------
Lewuathe wrote:

How about changing the message to be explicit what's wrong with the syntax? 

```suggestion
    transform.test_print_remark_at_operand %arg0 "should have ',' prior to this" : !transform.any_op
```

https://github.com/llvm/llvm-project/pull/75649


More information about the Mlir-commits mailing list