[Mlir-commits] [mlir] [mlir][vector] Add `extract(transpose(broadcast(x)))` canonicalization (PR #72616)

[Andrzej Warzyński]

================
@@ -2113,6 +2169,20 @@ llvm::SetVector<int64_t> BroadcastOp::computeBroadcastedUnitDims() {
                                       getResultVectorType().getShape());
 }
 
+llvm::SetVector<int64_t> BroadcastOp::computeRankExtendedDims() {
----------------
banach-space wrote:

[nit] Could you add a comment? I guess there are two types of broadcasts: 
* "rank-extending"
* "dim-1"
? Just double checking that my understanding is correct - I could find this documented anywhere.

https://github.com/llvm/llvm-project/pull/72616