[Mlir-commits] [llvm] [clang-tools-extra] [mlir] [clang] Make clang report garbage target versions. (PR #75373)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Thu Dec 14 01:23:17 PST 2023
zmodem wrote:
Thanks for looking at this. Silently ignoring bad inputs is usually not a good idea.
However, it would seem better to emit a proper diagnostic from the driver rather than calling exit in getOSDefines(). That way the regular diagnostic mechanisms can be used to decide what to do with it (treat as error, ignore, etc.).
https://github.com/llvm/llvm-project/pull/75373
More information about the Mlir-commits
mailing list