[Mlir-commits] [mlir] [mlir][SCF] Add `RecursiveMemoryEffects` to `scf.reduce` (PR #75314)

[Ivan Butygin]

Hardcode84 wrote:

> It could be useful to have such a "belongs to the enclosing op" (not sure what to call it) trait. The Terminator trait could have it as a dependent trait.

+1, yes, I think "belongs to the enclosing op" better conveys the intent, but I don't have a good short name either )


> Any reason the multiple scf.reduce can't be consolidated as a terminator?

yes, IMO this will be a better solution long term but it will be quite a lot of work and probably a lot of churn both upstream and downstream. We probably want trait as interim solution before this happens.

(but I'm just a passerby, who is the owner of SCF dialect?)

https://github.com/llvm/llvm-project/pull/75314