[Mlir-commits] [mlir] [flang][MLIR][OpenMP] Add support for `target update` directive. (PR #75047)
Akash Banerjee
llvmlistbot at llvm.org
Wed Dec 13 08:50:46 PST 2023
================
@@ -915,6 +925,33 @@ static LogicalResult verifyMapClause(Operation *op, OperandRange mapOperands) {
if (isa<ExitDataOp>(op) && to)
return emitError(op->getLoc(),
"from, release and delete map types are permitted");
+
+ if (isa<UpdateDataOp>(op)) {
+ if (del) {
+ return emitError(op->getLoc(),
+ "at least one of to or from map types must be "
+ "specified, other map types are not permitted");
+ }
+
+ if (to & from) {
----------------
TIFitis wrote:
Did you mean to use && instead of & here?
Regardless, I think we want to check for negation of exclusive or here so it should be `if(to == from)` then emit error.
This way we can get also get rid of the other if condition below.
https://github.com/llvm/llvm-project/pull/75047
More information about the Mlir-commits
mailing list