[Mlir-commits] [mlir] Add missing dep on MLIRToLLVMIRTranslationRegistration to mlir-opt. (PR #75111)

Stella Laurenzo llvmlistbot at llvm.org
Tue Dec 12 13:54:31 PST 2023


================
@@ -274,6 +274,10 @@ int main(int argc, char **argv) {
   DialectRegistry registry;
   registerAllDialects(registry);
   registerAllExtensions(registry);
+
+  // TODO: Remove this and the corresponding MLIRToLLVMIRTranslationRegistration
+  // cmake dependency when a safe dialect interface registration mechanism is
+  // implemented, see D157703 (and corresponding note on the declaration).
----------------
stellaraccident wrote:

I copied/adapted the TODO from the declaration that this is calling. It looked like this was all intended to be temporary and I wanted to make sure that when this line was removed that someone also removes the corresponding dep in CMake. I could take out the reference.

https://github.com/llvm/llvm-project/pull/75111


More information about the Mlir-commits mailing list