[Mlir-commits] [mlir] [mlir] NamedAttribute utility generator (PR #75118)

Mehdi Amini llvmlistbot at llvm.org
Tue Dec 12 13:32:44 PST 2023


================
@@ -283,6 +283,78 @@ class AttrDef<Dialect dialect, string name, list<Trait> traits = [],
                                  "::" # cppClassName # ">($_self)">;
 }
 
+// Define a StringAttr wrapper for the NamedAttribute `name`
----------------
joker-eph wrote:

The "NamedAttribute" part isn't clear to me.

Also this is more than a "wrapper", it seems to me this is actually registering its own full fledge attribute? 
I'm not sure I follow the definition, but I suspect this won't be uniqued with StringAttr.


https://github.com/llvm/llvm-project/pull/75118


More information about the Mlir-commits mailing list