[Mlir-commits] [mlir] [flang][MLIR][OpenMP] Add support for `target update` directive. (PR #75047)

[Kareem Ergawy]

================
@@ -1658,4 +1658,77 @@ func.func @omp_target_exit_data(%map1: memref<?xi32>) {
   return
 }
 
+// -----
+
+func.func @omp_target_update_data_if(%if_cond : i1) {
+  // expected-error @below {{`if` clause can appear at most once in the expansion of the oilist directive}}
+  omp.target_update_data if(%if_cond : i1) if(%if_cond : i1)
+  return
+}
----------------
ergawy wrote:

These test that we defined the op properly in TableGen, they guard against invalid op definition/change.

> ... which it isn't possible to create an mlir op.

Also, how do you guarantee that 😛?

I don't see harm in adding conservative testing.

https://github.com/llvm/llvm-project/pull/75047