[Mlir-commits] [mlir] Remove Pure attribute from Linalg::IndexOp. (PR #68894)

[llvmlistbot at llvm.org]

erick-xanadu wrote:


> > > we make nested linalg ops illegal then the above issue is potentially mute cause you would never have case where it would be illegal to cse linalg.index ops. This issue came about because someone tried to use nested linalg ops

> > Correction: I used inlining and a function call that uses linalg operations was inlined inside a linalg op.

> Having an operation of that granularity is also not the preferred path.

@MaheshRavishankar, when you are saying "having an operation of that granularity" you mean "having a call operation"? You are saying that having a call inside linalg is also not preferred?

> nor does lower to loops result in conversion of linalg operations to scalar code

Can you confirm that what you are also saying here is that lowering a nested linalg operations via `--convert-linalg-to-loops` does not work? Or what do you concretely mean "result in conversion to scalar code"? Can you provide a concrete example?

I ask because we have been using `--convert-linalg-to-loops` for a long time with no problems (except disabling CSE) to avoid this error.

https://github.com/llvm/llvm-project/pull/68894