[Mlir-commits] [mlir] [TOSA] Usage of 32bit integer for 'index to float' in rfft2d (PR #75098)

[Dmitriy Smirnov]

d-smirnov wrote:

Yep, the goal of the patch is to omit `index -> i64` conversion if possible
in lowering rfft2d Op as the subsequent transformation to SPIRV not able to
"easily'' handle 64bit integer arithmetic (which seems excessive in this
particular case anyway).

--
Dmitriy Smirnov


On Tue, 12 Dec 2023 at 15:46, Jakub Kuderski ***@***.***>
wrote:

> If this is due to conversion targets not being able to handle 64bit
> integer arithmetic "easily" or at all (e.g. SPIRV) then I think that this
> might require more discussion. Not sure how we can handle or if we need a
> more immediate casting operator from index to floating point that can be
> lowered later on as per target needs.
>
> FYI, I have patterns designed with this set of constraints in mind:
> https://github.com/llvm/llvm-project/blob/32532c2bbedc6e15eb3eae65cb6049e196cef9ad/mlir/lib/Dialect/Arith/Transforms/IntNarrowing.cpp#L396-L423
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/75098#issuecomment-1852301351>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGADO34YMXFCTTJMKQNPOXDYJB333AVCNFSM6AAAAABAQNLPVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJSGMYDCMZVGE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/75098