[Mlir-commits] [mlir] 8a5b448 - [mlir][GPU] Apply ClangTidy fixes

Adrian Kuegel llvmlistbot at llvm.org
Mon Dec 11 23:35:00 PST 2023


Author: Adrian Kuegel
Date: 2023-12-12T07:34:03Z
New Revision: 8a5b448fa04dc0a9b82321351e3d9a44cf00dab0

URL: https://github.com/llvm/llvm-project/commit/8a5b448fa04dc0a9b82321351e3d9a44cf00dab0
DIFF: https://github.com/llvm/llvm-project/commit/8a5b448fa04dc0a9b82321351e3d9a44cf00dab0.diff

LOG: [mlir][GPU] Apply ClangTidy fixes

Use const reference in loops if possible.

Added: 
    

Modified: 
    mlir/lib/Dialect/GPU/Transforms/SPIRVAttachTarget.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/GPU/Transforms/SPIRVAttachTarget.cpp b/mlir/lib/Dialect/GPU/Transforms/SPIRVAttachTarget.cpp
index a099a44f3dc6aa..88c365d9ce3eb6 100644
--- a/mlir/lib/Dialect/GPU/Transforms/SPIRVAttachTarget.cpp
+++ b/mlir/lib/Dialect/GPU/Transforms/SPIRVAttachTarget.cpp
@@ -64,13 +64,13 @@ void SPIRVAttachTarget::runOnOperation() {
   Version version = versionSymbol.value();
   SmallVector<Capability, 4> capabilities;
   SmallVector<Extension, 8> extensions;
-  for (auto cap : spirvCapabilities) {
+  for (const auto &cap : spirvCapabilities) {
     auto capSymbol = symbolizeCapability(cap);
     if (capSymbol)
       capabilities.push_back(capSymbol.value());
   }
   ArrayRef<Capability> caps(capabilities);
-  for (auto ext : spirvExtensions) {
+  for (const auto &ext : spirvExtensions) {
     auto extSymbol = symbolizeExtension(ext);
     if (extSymbol)
       extensions.push_back(extSymbol.value());


        


More information about the Mlir-commits mailing list