[Mlir-commits] [mlir] [mlir] Add support for recursive elements in DICompositeTypeAttr. (PR #74948)
Tobias Gysi
llvmlistbot at llvm.org
Mon Dec 11 23:23:14 PST 2023
gysit wrote:
@waj334 regarding the format I now saw that your suggestion comes from LLVM struct, which seems to put the mutable part in parenthesis? Let's follow their style then. It is always good to use existing stuff if there is precedence! Sorry didn't realize this yesterday.
Also, I wonder the parameter names even need to be printed in front of the parameters since there are only three fields left (id, info, elements). At least, if you introduce a di_composite_type_info attribute. Up to you to choose what makes more sense!
https://github.com/llvm/llvm-project/pull/74948
More information about the Mlir-commits
mailing list