[Mlir-commits] [mlir] Revert "[mlir][vector] Make `TransposeOpLowering` configurable (#73915)" (PR #75062)

Benjamin Maxwell llvmlistbot at llvm.org
Mon Dec 11 10:44:14 PST 2023


MacDue wrote:

> If I understand correctly, it is still needed by IREE. IREE pings llvm-project at https://github.com/shark-infra/llvm-project/commits/6cdda88cccc2e65803a893e3bca15bec9cf5d3f7 It includes the commit. If we revert it, it will break IREE in the next integrate.
> 
> ![image](https://private-user-images.githubusercontent.com/6949191/289628700-0ff0a7d8-1bcb-4966-91a3-f412036f6889.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDIzMjAyNzYsIm5iZiI6MTcwMjMxOTk3NiwicGF0aCI6Ii82OTQ5MTkxLzI4OTYyODcwMC0wZmYwYTdkOC0xYmNiLTQ5NjYtOTFhMy1mNDEyMDM2ZjY4ODkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQUlXTkpZQVg0Q1NWRUg1M0ElMkYyMDIzMTIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyMzEyMTFUMTgzOTM2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWE0YzRhMzAyMjYzYjc0YjFkOTEyMTVmZjk4NTkzYTA3ZTI2MGY0YmMyN2IyZDM4N2IxMDkzNjUwYjAyOWIzNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.oPtunDw9E3tMoCiQDWP7xkvmy6l_e2udmreRr38qLI8)

The change added here is not used in IREE. This added a config option to disabled using `shape_cast`s in LowerVectorTranspose.  
This was done to avoid issues for SPIR-V in IREE, however, instead the `shape_cast` lowerings were just enabled for SPIR-V ([see here](https://github.com/openxla/iree/commit/cef31e775e03ec83420e4a7b47a992242d8df37c#diff-6d56793c3d82ff66cbf63f0475f3cd37fdf0d6fe26c6e0a759108aa4dfba10c7)). So this option is entirely unused in IREE. 

https://github.com/llvm/llvm-project/pull/75062


More information about the Mlir-commits mailing list