[Mlir-commits] [mlir] 01ac530 - [mlir][ArmSME] Remove `vector.print` legality from ArmSMEToSCF (NFC) (#74875)

[llvmlistbot at llvm.org]

Author: Benjamin Maxwell
Date: 2023-12-11T11:25:43Z
New Revision: 01ac530a2ea3ee0c24b729a8f3c16ac85542cd15

URL: https://github.com/llvm/llvm-project/commit/01ac530a2ea3ee0c24b729a8f3c16ac85542cd15
DIFF: https://github.com/llvm/llvm-project/commit/01ac530a2ea3ee0c24b729a8f3c16ac85542cd15.diff

LOG: [mlir][ArmSME] Remove `vector.print` legality from ArmSMEToSCF (NFC) (#74875)

This was moved to VectorToArmSME in #74063, so this is no longer needed.

VectorToArmSME uses a greedy rewriter, so a similar legality rule is not
needed there.

See:
https://github.com/llvm/llvm-project/blob/bbb8a0df7367068e1cf2fc54edd376beb976b430/mlir/lib/Conversion/VectorToArmSME/VectorToArmSMEPass.cpp#L35

Added: 
    

Modified: 
    mlir/lib/Conversion/ArmSMEToSCF/ArmSMEToSCF.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Conversion/ArmSMEToSCF/ArmSMEToSCF.cpp b/mlir/lib/Conversion/ArmSMEToSCF/ArmSMEToSCF.cpp
index c3c9780318a9e..c9d7c0c313b5c 100644
--- a/mlir/lib/Conversion/ArmSMEToSCF/ArmSMEToSCF.cpp
+++ b/mlir/lib/Conversion/ArmSMEToSCF/ArmSMEToSCF.cpp
@@ -484,12 +484,6 @@ struct ConvertArmSMEToSCFPass
     target.addLegalDialect<arm_sme::ArmSMEDialect, vector::VectorDialect,
                            arith::ArithDialect, scf::SCFDialect>();
     target.addIllegalOp<arm_sme::TileLoadOp, arm_sme::TileStoreOp>();
-    target.addDynamicallyLegalOp<vector::PrintOp>([](vector::PrintOp op) {
-      if (!op.getSource())
-        return true;
-      VectorType vectorType = dyn_cast<VectorType>(op.getPrintType());
-      return !vectorType || !arm_sme::isValidSMETileVectorType(vectorType);
-    });
     if (failed(applyPartialConversion(getOperation(), target,
                                       std::move(patterns))))
       signalPassFailure();