[Mlir-commits] [mlir] [mlir] Add support for recursive elements in DICompositeTypeAttr. (PR #74948)

[Tobias Gysi]

https://github.com/gysit commented:

Nice!

I did a first pass trying to remember how mutable attributes work and added some comments and questions. One thing that may simplifying the parsing and printing a bit is factoring a helper attribute that contains the immutable payload data. That way we have less handwritten code to maintain.

Regarding the format change you are planing I guess it makes sense that the elements need to be at the end of the attribute. I would probably still try to keep a similar syntax compared to the other attributes and just produce an error in the parser if the elements are not at the end?

```
llvm.di_composite_type<id=distinct[0]<>, other = ..., attr = ..., params = ... , ...., elements = ... >
```
However, if another syntax makes it more explicit that the elements need to be at the end that sounds fine as well.





https://github.com/llvm/llvm-project/pull/74948