[Mlir-commits] [mlir] [mlir][ArmSME] Remove `vector.print` legality from ArmSMEToSCF (NFC) (PR #74875)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Benjamin Maxwell (MacDue)

<details>
<summary>Changes</summary>

This was moved to VectorToArmSME in #<!-- -->74063, so this is no longer needed.

VectorToArmSME uses a greedy rewriter, so a similar legality rule is not needed there.

See: https://github.com/llvm/llvm-project/blob/bbb8a0df7367068e1cf2fc54edd376beb976b430/mlir/lib/Conversion/VectorToArmSME/VectorToArmSMEPass.cpp#L35

---
Full diff: https://github.com/llvm/llvm-project/pull/74875.diff


1 Files Affected:

- (modified) mlir/lib/Conversion/ArmSMEToSCF/ArmSMEToSCF.cpp (-6) 


``````````diff
diff --git a/mlir/lib/Conversion/ArmSMEToSCF/ArmSMEToSCF.cpp b/mlir/lib/Conversion/ArmSMEToSCF/ArmSMEToSCF.cpp
index c3c9780318a9e9..c9d7c0c313b5c8 100644
--- a/mlir/lib/Conversion/ArmSMEToSCF/ArmSMEToSCF.cpp
+++ b/mlir/lib/Conversion/ArmSMEToSCF/ArmSMEToSCF.cpp
@@ -484,12 +484,6 @@ struct ConvertArmSMEToSCFPass
     target.addLegalDialect<arm_sme::ArmSMEDialect, vector::VectorDialect,
                            arith::ArithDialect, scf::SCFDialect>();
     target.addIllegalOp<arm_sme::TileLoadOp, arm_sme::TileStoreOp>();
-    target.addDynamicallyLegalOp<vector::PrintOp>([](vector::PrintOp op) {
-      if (!op.getSource())
-        return true;
-      VectorType vectorType = dyn_cast<VectorType>(op.getPrintType());
-      return !vectorType || !arm_sme::isValidSMETileVectorType(vectorType);
-    });
     if (failed(applyPartialConversion(getOperation(), target,
                                       std::move(patterns))))
       signalPassFailure();

``````````

</details>


https://github.com/llvm/llvm-project/pull/74875