[Mlir-commits] [mlir] [mlir][vector][spirv] Lower vector.maskedload and vector.maskedstore to SPIR-V (PR #74834)

[Jakub Kuderski]

https://github.com/kuhar commented:

Hi @Hsiangkai,

This looks very useful but I wonder if we should perform the expansion at the level of the vector dialect instead, like we do with ops like `vector.gather`: https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/Vector/Transforms/LowerVectorGather.cpp.

I know we had the same discussion under another PR recently: https://github.com/llvm/llvm-project/pull/69708#issuecomment-1793796731, so I wonder if you found staying at the level of the vector dialect problematic for some reason.

https://github.com/llvm/llvm-project/pull/74834