[Mlir-commits] [mlir] [mlir][affine] Remove `isValidAffineIndexOperand` (PR #73027)

[Rik Huijzer]

rikhuijzer wrote:

> > * value.getType().isIndex() is true
> >   
> >   * isValidDim is false which implies that isValidSymbol must be false
> >   * isValidDim is true which means that isValidDim(value, region) || isValidSymbol(value, region) must be true.
> 
> Sorry, I didn't get this part. If I understand correctly, the first case states if `isValidSymbol` is false, `isValidDim(value, region) || isValidSymbol(value, region)` is identical to `isValidDim(value, region)`. The second case is if `isValidSymbol` is true, `isValidDim(value, region) || isValidSymbol(value, region)` is identical to `isValidDim(value, region)` which is true anyway. Is my understanding correct?
> 
> Anyway, this change seems good. Could you resolve the conflict when you get a chance?

I tried to go through the logic again but I think I've made a mistake somewhere. I'll just close this. Thanks for your review anyway.

https://github.com/llvm/llvm-project/pull/73027