[Mlir-commits] [mlir] 345d574 - Apply clang-tidy fixes for llvm-prefer-isa-or-dyn-cast-in-conditionals in MapMemRefStorageClassPass.cpp (NFC)

Mehdi Amini llvmlistbot at llvm.org
Thu Dec 7 21:40:14 PST 2023


Author: Mehdi Amini
Date: 2023-12-07T21:39:25-08:00
New Revision: 345d574b6587ba90e24e5f30f069c8e27645d620

URL: https://github.com/llvm/llvm-project/commit/345d574b6587ba90e24e5f30f069c8e27645d620
DIFF: https://github.com/llvm/llvm-project/commit/345d574b6587ba90e24e5f30f069c8e27645d620.diff

LOG: Apply clang-tidy fixes for llvm-prefer-isa-or-dyn-cast-in-conditionals in MapMemRefStorageClassPass.cpp (NFC)

Added: 
    

Modified: 
    mlir/lib/Conversion/MemRefToSPIRV/MapMemRefStorageClassPass.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Conversion/MemRefToSPIRV/MapMemRefStorageClassPass.cpp b/mlir/lib/Conversion/MemRefToSPIRV/MapMemRefStorageClassPass.cpp
index 35a3af07940a83..c6ef5be2494ad3 100644
--- a/mlir/lib/Conversion/MemRefToSPIRV/MapMemRefStorageClassPass.cpp
+++ b/mlir/lib/Conversion/MemRefToSPIRV/MapMemRefStorageClassPass.cpp
@@ -205,7 +205,7 @@ spirv::MemorySpaceToStorageClassConverter::MemorySpaceToStorageClassConverter(
 static bool isLegalType(Type type) {
   if (auto memRefType = dyn_cast<BaseMemRefType>(type)) {
     Attribute spaceAttr = memRefType.getMemorySpace();
-    return spaceAttr && isa<spirv::StorageClassAttr>(spaceAttr);
+    return isa_and_nonnull<spirv::StorageClassAttr>(spaceAttr);
   }
   return true;
 }


        


More information about the Mlir-commits mailing list