[Mlir-commits] [mlir] [mlir][linalg] Expose getPreservedProducerResults method from ElementwiseOpFusion file (PR #73850)
Amir Bishara
llvmlistbot at llvm.org
Thu Dec 7 07:49:39 PST 2023
https://github.com/amirBish updated https://github.com/llvm/llvm-project/pull/73850
>From 4ac4db9430789c2cb08bb4d34241a1b96b2fb3a7 Mon Sep 17 00:00:00 2001
From: Amir Bishara <amir.bishara at mobileye.com>
Date: Wed, 29 Nov 2023 21:43:51 +0200
Subject: [PATCH] [mlir][linalg] Expose getPreservedProducerResults method from
ElementwiseOpFusion file
Declare `getPreservedProducerResults` function which helps
to get the preserved results of the producer linalg generic
operation as a result of elementwise fusion.
---
.../Dialect/Linalg/Transforms/Transforms.h | 4 +++
.../Linalg/Transforms/ElementwiseOpFusion.cpp | 30 ++++++++++++-------
2 files changed, 23 insertions(+), 11 deletions(-)
diff --git a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
index 3f4dfe42b71fd..1c7865d69a90c 100644
--- a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
+++ b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
@@ -494,6 +494,10 @@ struct ElementwiseOpFusionResult {
Operation *fusedOp;
llvm::DenseMap<Value, Value> replacements;
};
+/// Returns a set of indices of the producer's results which would
+/// be preserved after the fusion.
+llvm::SmallDenseSet<int> getPreservedProducerResults(GenericOp producer,
+ GenericOp consumer);
FailureOr<ElementwiseOpFusionResult>
fuseElementwiseOps(RewriterBase &rewriter, OpOperand *fusedOperand);
diff --git a/mlir/lib/Dialect/Linalg/Transforms/ElementwiseOpFusion.cpp b/mlir/lib/Dialect/Linalg/Transforms/ElementwiseOpFusion.cpp
index dc5ea28b67cdc..236ca0219e230 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/ElementwiseOpFusion.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/ElementwiseOpFusion.cpp
@@ -71,6 +71,23 @@ static AffineMap getIndexingMapOfProducerOperandsInCoordinatesOfFusedOp(
return t1.compose(fusedConsumerArgIndexMap);
}
+llvm::SmallDenseSet<int>
+mlir::linalg::getPreservedProducerResults(GenericOp producer,
+ GenericOp consumer) {
+ llvm::SmallDenseSet<int> preservedProducerResults;
+ for (const auto &producerResult : llvm::enumerate(producer->getResults())) {
+ auto *outputOperand = producer.getDpsInitOperand(producerResult.index());
+ if (producer.payloadUsesValueFromOperand(outputOperand) ||
+ !producer.canOpOperandsBeDropped(outputOperand) ||
+ llvm::any_of(producerResult.value().getUsers(), [&](Operation *user) {
+ return user != consumer.getOperation();
+ })) {
+ preservedProducerResults.insert(producerResult.index());
+ }
+ }
+ return preservedProducerResults;
+}
+
/// Conditions for elementwise fusion of generic operations.
bool mlir::linalg::areElementwiseOpsFusable(OpOperand *fusedOperand) {
if (!fusedOperand)
@@ -285,17 +302,8 @@ mlir::linalg::fuseElementwiseOps(RewriterBase &rewriter,
assert(consumer.isDpsInput(fusedOperand) &&
"expected producer of input operand");
/// Find the results of the producer that have uses outside of the consumer.
- llvm::SmallDenseSet<int> preservedProducerResults;
- for (const auto &producerResult : llvm::enumerate(producer->getResults())) {
- auto *outputOperand = producer.getDpsInitOperand(producerResult.index());
- if (producer.payloadUsesValueFromOperand(outputOperand) ||
- !producer.canOpOperandsBeDropped(outputOperand) ||
- llvm::any_of(producerResult.value().getUsers(), [&](Operation *user) {
- return user != consumer.getOperation();
- })) {
- preservedProducerResults.insert(producerResult.index());
- }
- }
+ llvm::SmallDenseSet<int> preservedProducerResults =
+ getPreservedProducerResults(producer, consumer);
// Compute the fused operands list and indexing maps.
SmallVector<Value> fusedInputOperands, fusedOutputOperands;
More information about the Mlir-commits
mailing list