[Mlir-commits] [mlir] [Flang] [MLIR] [OpenMP] Add initial MLIR op support for OMP TARGET UPDATE directive (PR #74699)

[Kareem Ergawy]

================
@@ -1416,6 +1416,50 @@ def TargetOp : OpenMP_Op<"target",[IsolatedFromAbove, OutlineableOpenMPOpInterfa
   let hasVerifier = 1;
 }
 
+//===---------------------------------------------------------------------===//
+// 2.14.6 target update data Construct
----------------
ergawy wrote:

I see the section numbers from the spec are used across all op definitions, but I think this might cause confusion since section numbers change across versions. I see, for example, `2.12.7 Declare Target Directive` where the section number comes from 5.0, I think, while here we use `2.14.6` which comes from 5.1 AFAICT.

Maybe instead of section numbers, we should use the latest spec version (partially) supported by the current implementation of the op?

https://github.com/llvm/llvm-project/pull/74699