[Mlir-commits] [mlir] [mlir][Transforms] GreedyPatternRewriteDriver: verify IR after pattern application (PR #74270)

[Ivan Butygin]

Hardcode84 wrote:

I don't ask to change code immediately and I don't know what the best solution is, juts some usability concerns.

> Another problem with this approach is that there is currently no API to signal a pass failure from the greedy pattern rewrite driver. 
`applyPatternsAndFoldGreedily` returns `LogicalResult` so it can be propagated as pass failure but I still see a lot of `(void)applyPatternsAndFoldGreedily` code in repo (mostly in test passes).

https://github.com/llvm/llvm-project/pull/74270