[Mlir-commits] [mlir] [mlir][transform] TrackingListener: Improve dead handles detection (PR #74290)
Matthias Springer
llvmlistbot at llvm.org
Tue Dec 5 23:30:58 PST 2023
================
@@ -1319,10 +1339,8 @@ void transform::TrackingListener::notifyOperationReplaced(
// If the op is tracked but no replacement op was found, send a
// notification.
if (!diag.succeeded()) {
- diag.attachNote((*firstAliveUser)->getOwner()->getLoc())
- << "replacement is required because alive handle(s) exist "
- << "(first use in this op as operand number "
- << (*firstAliveUser)->getOperandNumber() << ")";
----------------
matthias-springer wrote:
I tried to, but it would make the API quite complex. `SkipHandleFn` is pretty simple in the current implementation: is the handle needed or not. It would have to return a user, but the name "skip handle function" would not make sense anymore and we would have to mention the concept of liveness in the `TrackingListener`.
https://github.com/llvm/llvm-project/pull/74290
More information about the Mlir-commits
mailing list