[Mlir-commits] [mlir] [MLIR][LLVM] Fuse Scope into CallsiteLoc Callee (PR #74546)

Christian Ulmann llvmlistbot at llvm.org
Tue Dec 5 22:49:27 PST 2023


https://github.com/Dinistro approved this pull request.

LGTM % one comment. Thanks for working on this.

Regarding the semantic definition: I stumbled over this a while ago, and I agree that the current style of allowing Fused locations everywhere is very confusing and hard to map to LLVM in any reasonable way. If we can enforce that scopes are only attached to leaf locations, that would be a nice simplification.
Disclaimer: I need to think about this for a bit before I can state that this change would indeed be correct.

https://github.com/llvm/llvm-project/pull/74546


More information about the Mlir-commits mailing list