[Mlir-commits] [mlir] Reland "[mlir] Fix TileUsingForOp attr-dict printing/parsing" (PR #73261)

Mehdi Amini llvmlistbot at llvm.org
Tue Dec 5 00:46:50 PST 2023


================
@@ -1819,7 +1819,7 @@ def TileUsingForOp : Op<Transform_Dialect, "structured.tile_using_for",
   let arguments = (ins TransformHandleTypeInterface:$target,
                    Variadic<TransformParamTypeOrAnyHandle>:$dynamic_sizes,
                    DefaultValuedOptionalAttr<DenseI64ArrayAttr, "{}">:$static_sizes,
-                   DefaultValuedOptionalAttr<DenseI64ArrayAttr, "{}">:$interchange,
+                   DefaultValuedOptionalAttr<I64ArrayAttr, "{}">:$interchange,
----------------
joker-eph wrote:

Let's not do that: `I64ArrayAttr` is a legacy construct, keeping the more modern `DenseI64ArrayAttr` seems preferable and I rather not mixup inherent attribute here anyway.

https://github.com/llvm/llvm-project/pull/73261


More information about the Mlir-commits mailing list