[Mlir-commits] [mlir] [MLIR][LLVM] Translate Debug EmissionKind (PR #74376)

Tobias Gysi llvmlistbot at llvm.org
Tue Dec 5 00:23:27 PST 2023


================
@@ -102,7 +102,9 @@ llvm::DICompileUnit *DebugTranslation::translateImpl(DICompileUnitAttr attr) {
       attr.getSourceLanguage(), translate(attr.getFile()),
       attr.getProducer() ? attr.getProducer().getValue() : "",
       attr.getIsOptimized(),
-      /*Flags=*/"", /*RV=*/0);
+      /*Flags=*/"", /*RV=*/0, /*SplitName=*/{},
+      static_cast<llvm::DICompileUnit::DebugEmissionKind>(
----------------
gysit wrote:

Yeah I guess I would prefer if we use LLVM enums since there are no large switch statements needed (I assume that is what you refer to by explicit mappings)? But this is unrelated to your PR. I just realized that things are a bit inconsistent in that regard.

https://github.com/llvm/llvm-project/pull/74376


More information about the Mlir-commits mailing list