[Mlir-commits] [mlir] [mlir][llvm] Fix attribute printer warning (PR #74351)

[Tobias Gysi]

https://github.com/gysit created https://github.com/llvm/llvm-project/pull/74351

This commit fixes a compilation warning caused by the printExpressionArg that returns LogicalResult instead of void.

The warning has been introduce by commit 6da578c.

>From 179f79374eda160dcb638ac5f54a7a69768b3982 Mon Sep 17 00:00:00 2001
From: Tobias Gysi <tobias.gysi at nextsilicon.com>
Date: Mon, 4 Dec 2023 17:40:39 +0000
Subject: [PATCH] [mlir][llvm] Fix attribute printer warning

This commit fixes a compilation warning caused by the
printExpressionArg that returns LogicalResult instead of void.

The warning has been introduce by commit 6da578c.
---
 mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp
index 053524679ece7..e2342670508ce 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp
@@ -31,8 +31,8 @@ static LogicalResult parseExpressionArg(AsmParser &parser, uint64_t opcode,
 
 /// Prints DWARF expression arguments with respect to the specific DWARF
 /// operation. Some operands are printed in their textual form.
-static LogicalResult printExpressionArg(AsmPrinter &printer, uint64_t opcode,
-                                        ArrayRef<uint64_t> args);
+static void printExpressionArg(AsmPrinter &printer, uint64_t opcode,
+                               ArrayRef<uint64_t> args);
 
 #include "mlir/Dialect/LLVMIR/LLVMOpsEnums.cpp.inc"
 #define GET_ATTRDEF_CLASSES
@@ -166,8 +166,8 @@ LogicalResult parseExpressionArg(AsmParser &parser, uint64_t opcode,
   return parser.parseCommaSeparatedList(operandParser);
 }
 
-LogicalResult printExpressionArg(AsmPrinter &printer, uint64_t opcode,
-                                 ArrayRef<uint64_t> args) {
+void printExpressionArg(AsmPrinter &printer, uint64_t opcode,
+                        ArrayRef<uint64_t> args) {
   size_t i = 0;
   llvm::interleaveComma(args, printer, [&](uint64_t operand) {
     if (i > 0 && opcode == llvm::dwarf::DW_OP_LLVM_convert) {
@@ -182,5 +182,4 @@ LogicalResult printExpressionArg(AsmPrinter &printer, uint64_t opcode,
     printer << operand;
     i++;
   });
-  return success();
 }