[Mlir-commits] [llvm] [mlir] fix linking on riscv64 (PR #74167)

Vincent Palatin llvmlistbot at llvm.org
Mon Dec 4 01:31:03 PST 2023


================
@@ -16,4 +16,6 @@ add_mlir_library(MLIRPass
   LINK_LIBS PUBLIC
   MLIRAnalysis
   MLIRIR
+  PRIVATE
+  ${LLVM_ATOMIC_LIB}
----------------
vpalatin wrote:

fair point
I just put it in the specific places where it was needed (ie using the libatomic symbols) the same way it was done in other places in llvm (mlir never had support for this case).
but this will require some 'manual' maintenance as it is not obvious where these functions are used.
adding it globally to the helper might be a better avenue.

https://github.com/llvm/llvm-project/pull/74167


More information about the Mlir-commits mailing list