[Mlir-commits] [mlir] [MLIR] Add support for frame pointers in MLIR (PR #72145)

[Tobias Gysi]

================
@@ -249,6 +249,12 @@ module {
     // CHECK-SAME: vscale_range(1, 2)
     llvm.return
   }
+
+  llvm.func @frame_pointer_roundtrip() attributes {frame_pointer = #llvm.framePointerKind<"non-leaf">} {
+    // CHECK: @frame_pointer_roundtrip()
+    // CHECK-SAME: attributes {frame_pointer = #llvm.framePointerKind<"non-leaf">}
+    llvm.return
+  }
----------------
gysit wrote:

```suggestion
  // CHECK-LABEL: @frame_pointer_roundtrip()
  // CHECK-SAME: attributes {frame_pointer = #llvm.framePointerKind<"non-leaf">}  
  llvm.func @frame_pointer_roundtrip() attributes {frame_pointer = #llvm.framePointerKind<"non-leaf">} {
    llvm.return
  }
```
The check lines that match the function should usually be right above the function. We usually use CHECK-LABEL when matching the function name. I know that the example above is not perfect...

https://github.com/llvm/llvm-project/pull/72145