[Mlir-commits] [mlir] [mlir][Complex] Fix bug in `MergeComplexBitcast` (PR #74271)

[Matthias Springer]

matthias-springer wrote:

Should we fix "bugs" like this one? Is it actually bug? I think there is at the moment no requirement that the IR has to verify after each pattern application.

I was looking into this because I had to debug a pass that applies multiple patterns and I wanted to see how an op was getting simplified. So I was running with `-debug`. Then I saw invalid IR half way through the process and I thought "if the IR already broken at this point, I don't even have to look further".


https://github.com/llvm/llvm-project/pull/74271