[Mlir-commits] [mlir] [mlir][bufferization] Fix op dominance bug in rewrite pattern (PR #74159)

[Matthias Springer]

matthias-springer wrote:

> We're missing a test don't we?

I tried to write one but there was always some other pattern (or the folder), which cleaned up the IR again. Maybe it's not possible to trigger this bug without adding an option to the pass to only apply this one pattern.

I only noticed this issue because I was running with `-debug`. Maybe we could have a new MLIR flag that triggers the verifier after each pattern application? We could pass this flag in unit tests. (Similar to the `test-convergence` pass option of the canonicalizer, but this would probably have to be a `mlir-opt` option.)


https://github.com/llvm/llvm-project/pull/74159