[Mlir-commits] [mlir] [mlir] Add support for DIGlobalVariable and DIGlobalVariableExpression (PR #73367)

[Tobias Gysi]

================
@@ -237,10 +237,26 @@ define void @bar() {
 
 ; // -----
 
-; Visibility attribute.
-
-; CHECK: llvm.mlir.global external hidden constant @hidden("string")
- at hidden = hidden constant [6 x i8] c"string"
-
-; CHECK: llvm.mlir.global external protected constant @protected(42 : i64)
- at protected = protected constant i64 42
+; // CHECK-DAG: #[[TYPE:.*]] = #llvm.di_basic_type<tag = DW_TAG_base_type, name = "int", sizeInBits = 32, encoding = DW_ATE_signed>
----------------
gysit wrote:

```suggestion
; CHECK-DAG: #[[TYPE:.*]] = #llvm.di_basic_type<tag = DW_TAG_base_type, name = "int", sizeInBits = 32, encoding = DW_ATE_signed>
```
nit: please drop the // in .ll files here and below.

https://github.com/llvm/llvm-project/pull/73367