[Mlir-commits] [mlir] [mlir][mesh] Add TableGen deffinitions of more collective ops (PR #73842)

Chengji Yao llvmlistbot at llvm.org
Fri Dec 1 13:49:22 PST 2023


================
@@ -507,6 +508,43 @@ void AllToAllOp::getCanonicalizationPatterns(RewritePatternSet &patterns,
   patterns.add<EmptyMeshAxesCanonicalizationPattern<AllToAllOp>>(context);
 }
 
+//===----------------------------------------------------------------------===//
+// mesh.broadcast op
+//===----------------------------------------------------------------------===//
+
+LogicalResult
+BroadcastOp::verifySymbolUses(SymbolTableCollection &symbolTable) {
+  // TODO
----------------
yaochengji wrote:

I think we should at least add basic test in the `ops.mlir` file even though the verification functions are left as TODO.

https://github.com/llvm/llvm-project/pull/73842


More information about the Mlir-commits mailing list