[Mlir-commits] [mlir] 6a0e536 - [mlir] Fully qualify typenames in SymbolInterfaces.td

Markus Böck llvmlistbot at llvm.org
Fri Aug 18 13:30:29 PDT 2023


Author: Nils McCarthy
Date: 2023-08-18T22:29:41+02:00
New Revision: 6a0e536ccfef1f7bd64ee4153b4efc0aeecf28d4

URL: https://github.com/llvm/llvm-project/commit/6a0e536ccfef1f7bd64ee4153b4efc0aeecf28d4
DIFF: https://github.com/llvm/llvm-project/commit/6a0e536ccfef1f7bd64ee4153b4efc0aeecf28d4.diff

LOG: [mlir] Fully qualify typenames in SymbolInterfaces.td

Differential Revision: https://reviews.llvm.org/D158305

Added: 
    

Modified: 
    mlir/include/mlir/IR/SymbolInterfaces.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/IR/SymbolInterfaces.td b/mlir/include/mlir/IR/SymbolInterfaces.td
index a3a6833a475b85..3da9dedeb8bdcf 100644
--- a/mlir/include/mlir/IR/SymbolInterfaces.td
+++ b/mlir/include/mlir/IR/SymbolInterfaces.td
@@ -31,7 +31,7 @@ def Symbol : OpInterface<"SymbolOpInterface"> {
 
   let methods = [
     InterfaceMethod<"Returns the name of this symbol.",
-      "StringAttr", "getNameAttr", (ins), [{
+      "::mlir::StringAttr", "getNameAttr", (ins), [{
         // Don't rely on the trait implementation as optional symbol operations
         // may override this.
         return mlir::SymbolTable::getSymbolName($_op);
@@ -178,13 +178,13 @@ def Symbol : OpInterface<"SymbolOpInterface"> {
     using Visibility = mlir::SymbolTable::Visibility;
 
     /// Convenience version of `getNameAttr` that returns a StringRef.
-    StringRef getName() {
+    ::mlir::StringRef getName() {
       return getNameAttr().getValue();
     }
 
     /// Convenience version of `setName` that take a StringRef.
-    void setName(StringRef name) {
-      setName(StringAttr::get($_op->getContext(), name));
+    void setName(::mlir::StringRef name) {
+      setName(::mlir::StringAttr::get($_op->getContext(), name));
     }
   }];
 


        


More information about the Mlir-commits mailing list