[Mlir-commits] [mlir] 6d0ca5a - [MLIR][OpenMP][test] Update omp::FlagsAttr tests to only use CHECK tests

[Andrew Gozillon]

Author: Andrew Gozillon
Date: 2023-04-27T09:23:39-05:00
New Revision: 6d0ca5ae4c5ada004934c56bbe4d7c5db765a209

URL: https://github.com/llvm/llvm-project/commit/6d0ca5ae4c5ada004934c56bbe4d7c5db765a209
DIFF: https://github.com/llvm/llvm-project/commit/6d0ca5ae4c5ada004934c56bbe4d7c5db765a209.diff

LOG: [MLIR][OpenMP][test] Update omp::FlagsAttr tests to only use CHECK tests

The CHECK-NOT tests were incorrect and impacting the other
tests flag tests negatively, they'd pass as false positives.

Added: 
    

Modified: 
    mlir/test/Target/LLVMIR/openmp-llvm.mlir

Removed: 
    


################################################################################
diff  --git a/mlir/test/Target/LLVMIR/openmp-llvm.mlir b/mlir/test/Target/LLVMIR/openmp-llvm.mlir
index 4be992376eb76..0e11d677aa590 100644
--- a/mlir/test/Target/LLVMIR/openmp-llvm.mlir
+++ b/mlir/test/Target/LLVMIR/openmp-llvm.mlir
@@ -2457,17 +2457,6 @@ llvm.func @omp_opaque_pointers(%arg0 : !llvm.ptr, %arg1: !llvm.ptr, %expr: i32)
 
 // -----
 
-// CHECK-NOT: @__omp_rtl_debug_kind = weak_odr hidden constant i32 1
-// CHECK-NOT: @__omp_rtl_assume_teams_oversubscription = weak_odr hidden constant i32 1
-// CHECK-NOT: @__omp_rtl_assume_threads_oversubscription = weak_odr hidden constant i32 1
-// CHECK-NOT: @__omp_rtl_assume_no_thread_state = weak_odr hidden constant i32 1
-// CHECK-NOT: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 1
-module attributes {omp.flags = #omp.flags<debug_kind = 1, assume_teams_oversubscription = true, 
-                                          assume_threads_oversubscription = true, assume_no_thread_state = true, 
-                                          assume_no_nested_parallelism = true>} {}
-
-// -----
-
 // CHECK: @__omp_rtl_debug_kind = weak_odr hidden constant i32 1
 // CHECK: @__omp_rtl_assume_teams_oversubscription = weak_odr hidden constant i32 1
 // CHECK: @__omp_rtl_assume_threads_oversubscription = weak_odr hidden constant i32 1
@@ -2475,18 +2464,7 @@ module attributes {omp.flags = #omp.flags<debug_kind = 1, assume_teams_oversubsc
 // CHECK: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 1
 module attributes {omp.flags = #omp.flags<debug_kind = 1, assume_teams_oversubscription = true, 
                                           assume_threads_oversubscription = true, assume_no_thread_state = true, 
-                                          assume_no_nested_parallelism = true>, 
-                   omp.is_device = #omp.isdevice<is_device = true>} {}
-
-// -----
-
-// CHECK-NOT: @__omp_rtl_debug_kind = weak_odr hidden constant i32 0
-// CHECK-NOT: @__omp_rtl_assume_teams_oversubscription = weak_odr hidden constant i32 0
-// CHECK-NOT: @__omp_rtl_assume_threads_oversubscription = weak_odr hidden constant i32 0
-// CHECK-NOT: @__omp_rtl_assume_no_thread_state = weak_odr hidden constant i32 0
-// CHECK-NOT: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 0
-module attributes {omp.flags = #omp.flags<>} {}
-
+                                          assume_no_nested_parallelism = true>} {}
 // -----
 
 // CHECK: @__omp_rtl_debug_kind = weak_odr hidden constant i32 0
@@ -2494,18 +2472,7 @@ module attributes {omp.flags = #omp.flags<>} {}
 // CHECK: @__omp_rtl_assume_threads_oversubscription = weak_odr hidden constant i32 0
 // CHECK: @__omp_rtl_assume_no_thread_state = weak_odr hidden constant i32 0
 // CHECK: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 0
-module attributes {omp.flags = #omp.flags<>, omp.is_device = #omp.isdevice<is_device = true>} {}
-
-// -----
-
-// CHECK-NOT: @__omp_rtl_debug_kind = weak_odr hidden constant i32 0
-// CHECK-NOT: @__omp_rtl_assume_teams_oversubscription = weak_odr hidden constant i32 0
-// CHECK-NOT: @__omp_rtl_assume_threads_oversubscription = weak_odr hidden constant i32 0
-// CHECK-NOT: @__omp_rtl_assume_no_thread_state = weak_odr hidden constant i32 0
-// CHECK-NOT: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 0
-module attributes {omp.flags = #omp.flags<debug_kind = 0, assume_teams_oversubscription = false, 
-                                          assume_threads_oversubscription = false, assume_no_thread_state = false, 
-                                          assume_no_nested_parallelism = false>} {}
+module attributes {omp.flags = #omp.flags<>} {}
 
 // -----
 
@@ -2516,17 +2483,7 @@ module attributes {omp.flags = #omp.flags<debug_kind = 0, assume_teams_oversubsc
 // CHECK: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 0
 module attributes {omp.flags = #omp.flags<debug_kind = 0, assume_teams_oversubscription = false, 
                                           assume_threads_oversubscription = false, assume_no_thread_state = false, 
-                                          assume_no_nested_parallelism = false>, 
-                   omp.is_device = #omp.isdevice<is_device = true>} {}
-
-// -----
-
-// CHECK-NOT: @__omp_rtl_debug_kind = weak_odr hidden constant i32 0
-// CHECK-NOT: @__omp_rtl_assume_teams_oversubscription = weak_odr hidden constant i32 1
-// CHECK-NOT: @__omp_rtl_assume_threads_oversubscription = weak_odr hidden constant i32 0
-// CHECK-NOT: @__omp_rtl_assume_no_thread_state = weak_odr hidden constant i32 1
-// CHECK-NOT: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 0
-module attributes {omp.flags = #omp.flags<assume_teams_oversubscription = true, assume_no_thread_state = true>} {}
+                                          assume_no_nested_parallelism = false>} {}
 
 // -----
 
@@ -2535,5 +2492,4 @@ module attributes {omp.flags = #omp.flags<assume_teams_oversubscription = true,
 // CHECK: @__omp_rtl_assume_threads_oversubscription = weak_odr hidden constant i32 0
 // CHECK: @__omp_rtl_assume_no_thread_state = weak_odr hidden constant i32 1
 // CHECK: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 0
-module attributes {omp.flags = #omp.flags<assume_teams_oversubscription = true, assume_no_thread_state = true>, 
-                   omp.is_device = #omp.isdevice<is_device = true>} {}
+module attributes {omp.flags = #omp.flags<assume_teams_oversubscription = true, assume_no_thread_state = true>} {}