[Mlir-commits] [mlir] 919fcab - [mlir:PDLL] Actually run the integration tests

River Riddle llvmlistbot at llvm.org
Thu Sep 1 12:37:37 PDT 2022


Author: River Riddle
Date: 2022-09-01T12:37:18-07:00
New Revision: 919fcab6e2f48fdcb3911302958514cce2e01387

URL: https://github.com/llvm/llvm-project/commit/919fcab6e2f48fdcb3911302958514cce2e01387
DIFF: https://github.com/llvm/llvm-project/commit/919fcab6e2f48fdcb3911302958514cce2e01387.diff

LOG: [mlir:PDLL] Actually run the integration tests

This revealed that the test was a bit out of date and failing, this
commit also tweaks the .mlir to actually test pdll properly.

Added: 
    

Modified: 
    mlir/test/mlir-pdll/Integration/test-pdll.mlir
    mlir/test/mlir-pdll/lit.local.cfg

Removed: 
    


################################################################################
diff  --git a/mlir/test/mlir-pdll/Integration/test-pdll.mlir b/mlir/test/mlir-pdll/Integration/test-pdll.mlir
index 7118a2ad4aa12..baaffc74bf1f1 100644
--- a/mlir/test/mlir-pdll/Integration/test-pdll.mlir
+++ b/mlir/test/mlir-pdll/Integration/test-pdll.mlir
@@ -1,17 +1,17 @@
 // RUN: mlir-opt %s -test-pdll-pass | FileCheck %s
 
 // CHECK-LABEL: func @simpleTest
-func @simpleTest() {
+func.func @simpleTest() {
   // CHECK: test.success
   "test.simple"() : () -> ()
   return
 }
 
 // CHECK-LABEL: func @testImportedInterface
-func @testImportedInterface() {
+func.func @testImportedInterface() -> i1 {
   // CHECK: test.non_cast
   // CHECK: test.success
   "test.non_cast"() : () -> ()
-  "builtin.unrealized_conversion_cast"() : () -> (i1)
-  return
+  %value = "builtin.unrealized_conversion_cast"() : () -> (i1)
+  return %value : i1
 }

diff  --git a/mlir/test/mlir-pdll/lit.local.cfg b/mlir/test/mlir-pdll/lit.local.cfg
index f03f17e880379..c438027edc2c4 100644
--- a/mlir/test/mlir-pdll/lit.local.cfg
+++ b/mlir/test/mlir-pdll/lit.local.cfg
@@ -1,2 +1,2 @@
-config.suffixes = ['.pdll']
+config.suffixes = ['.pdll', '.mlir']
 config.excludes = ['include']


        


More information about the Mlir-commits mailing list